Concluding v6 deprecation cycle #1054
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
There was a problem hiding this comment.
Pull Request Overview
This pull request completes the v6 deprecation cycle by removing deprecated functionality that was marked for removal in version 6. The changes eliminate deprecated classes, methods, fields, and warnings that were previously part of the API.
Key changes include:
- Removal of deprecated
Answerclass and various synchronous methods - Cleanup of deprecated configuration fields and their validation logic
- Removal of deprecated function parameters and warning infrastructure
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_paperqa.py | Removes deprecated test cases and import for Answer class |
| src/paperqa/types.py | Removes deprecated Answer class and warning imports |
| src/paperqa/settings.py | Removes deprecated configuration fields and validation logic |
| src/paperqa/docs.py | Removes deprecated synchronous methods and warning infrastructure |
| src/paperqa/agents/search.py | Removes deprecated parameters and validation from get_directory_index |
| src/paperqa/init.py | Removes deprecated imports and warning filters |
| README.md | Updates documentation to reflect new configuration structure |
jamesbraza
force-pushed
the
deprecations
branch
from
717e620 to
5ed423f
Compare
jamesbraza
force-pushed
the
deprecations
branch
from
5ed423f to
7275309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR title